Should have / Shouldn’t have for criticism and regret
Two sides of one pattern
In a context of regret, should have + V3 often means it would have been better to do something, but it was not done. Shouldn’t have + V3 often criticises an action that was performed. These are the uses practised in this lesson.
The form alone does not always confirm what happened. You should have called her — I hope you did can express a past obligation when the outcome is unknown. In examples of regret and criticism, rely on the additional facts.
evaluating the past: should have + V3 — it was advisable to do it; shouldn’t have + V3 — it was wrong to do it
- V3 / past participle —
- The third verb form: worked, gone, seen. Used after have/has or in the passive, for example; it is not always the same as V2.
I should have checked the train times; now I've missed the last one.
I should have checked the train times; now I've missed the last one.
The checking did not happen and there is a consequence: regret about an action left undone.
She shouldn't have posted the photo without asking.
She shouldn't have posted the photo without asking.
The photo was posted and the speaker disapproves: criticism of an action performed.
We should have left earlier, but we didn't.
We should have left earlier, but we didn't.
The but-clause explicitly states the fact: they did not leave earlier.
Regret about yourself and criticism of someone else
With I/we, this pattern often expresses regret or self-criticism; with you, it often reproaches the listener. However, the pronoun does not automatically determine the tone: the statement may be a neutral evaluation or sympathy. Consider the content and intonation.
To soften criticism, speakers add words such as perhaps or I think and discuss the consequence rather than blame. This does not affect the grammar, but tone matters in correspondence and at work.
We should have trusted the second quote instead.
We should have trusted the second quote instead.
Possible self-criticism of a shared decision. We alone does not rule out blaming other participants.
You should have told me about the deadline.
You should have told me about the deadline.
Criticism of the listener: the deadline was not communicated.
Perhaps you should have mentioned it to the team first.
Perhaps you should have mentioned it to the team first.
The same idea, softened by perhaps.
Form: modal, have and past participle
Should / shouldn’t is always followed by have and then the past participle (V3): should have gone, shouldn’t have said. A base form (should have go), past tense form (should have went) and should had are errors.
In speech, should have is often pronounced as should’ve, leading learners sometimes to write should of. This is incorrect: of does not belong here; it reflects the sound of contracted have. The full negative form is should not have; the contraction is shouldn’t have.
Ought to in the past has the same meaning: ought to have called. Passive and continuous forms add be: should have been told (passive), should have been working (a past action in progress).
should/shouldn’t have + V3; passive: should have been + V3; process: should have been + -ing
- V3 / past participle —
- The third verb form: worked, gone, seen. Used after have/has or in the passive, for example; it is not always the same as V2.
- V-ing / -ing —
- The verb form ending in -ing: working, going. Its role depends on the construction.
He should have gone to the doctor sooner.
He should have gone to the doctor sooner.
The irregular V3 form of go is gone, not went.
The staff should have been told about the change.
The staff should have been told about the change.
Passive: should have been + V3.
You shouldn't have been driving so fast in the rain.
You shouldn't have been driving so fast in the rain.
A past action in progress: shouldn’t have been + V-ing.
Questions and short answers
In a question, should moves before the subject: Should she have called him? Natural short answers are Yes, she should have / No, she shouldn’t have. When the context is clear, shorter Yes, she should is also possible.
Put the question word before this pattern: What should I have done? Why shouldn’t she have said that? Shouldn’t you have asked first? can sound like a reproach or a check of what the right action was.
Should we have warned the neighbours about the noise?
Should we have warned the neighbours about the noise?
The question asks whether giving a warning was the right thing to do. It does not itself confirm whether a warning was given.
What should he have done instead?
What should he have done instead?
The order is What + should + he + have + done. Other words, such as instead, can follow the verb.
Shouldn't you have asked her first?
Shouldn't you have asked her first?
A negative question with a reproachful nuance.
A consequence or reason in the same sentence
A consequence or reason helps make regret or criticism clear. You can add one with now, because or but; however, short I should have called is also complete if the situation is already known.
Do not build formulaic pairs. Look at the facts: was the action performed? If a desirable action was not performed, use should have; if it was performed but should not have been, use shouldn’t have.
I should have saved the file, so now I have to retype everything.
I should have saved the file, so now I have to retype everything.
The saving did not happen; so explains the consequence.
They shouldn't have painted the walls yellow because the room looks smaller now.
They shouldn't have painted the walls yellow because the room looks smaller now.
The walls were painted; because explains why this was a mistake.
Scope: neighbouring modal meanings
Could have + V3 can describe an unused opportunity, while would have + V3 describes an imagined result. Should have adds an evaluation: it was the right action, so failing to do it was a mistake. Neighbouring materials develop the connections; here you only need to recognise the difference.
Should also gives advice in the present: You should rest is advice now. For the past, it becomes should have rested: the advice has come too late. We do not study the separate use of should have + V3 for a reasonable expectation (The parcel should have arrived by now) here; the focus remains regret and criticism.
You should rest now. You should have rested yesterday.
You should rest now. You should have rested yesterday.
Present advice versus a belated evaluation of the past.
You could have rested, but you chose to work.
You could have rested, but you chose to work.
Could have names an opportunity without evaluating it as the right choice.
If you had rested, you would have felt better.
If you had rested, you would have felt better.
Would have depicts an imagined result, covered in a neighbouring rule.
Common mistakes
Incorrect:I should of called him back.
Correct:I should have called him back.
Of is a misspelling caused by the pronunciation of should’ve; have is needed.
Incorrect:She shouldn't have went alone.
Correct:She shouldn't have gone alone.
After have, use the past participle gone, not the past tense went.
Incorrect:You should had asked me first.
Correct:You should have asked me first.
The modal is followed by have, not had.
Incorrect:We should told them the truth.
Correct:We should have told them the truth.
Without have, the construction loses its past reference: should have + V3 is needed.
Incorrect:He shouldn't have say that to her.
Correct:He shouldn't have said that to her.
After have, use V3 (said), not the base form.
Incorrect:Should have you called the office?
Correct:Should you have called the office?
Only should moves to the beginning in the question; have stays beside V3.